flyrain commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1911495617


##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -240,6 +242,13 @@ public static void toJson(TableMetadata metadata, 
JsonGenerator generator) throw
     }
     generator.writeEndArray();
 
+    if (metadata.formatVersion() == 3) {
+      generator.writeBooleanField(ROW_LINEAGE, metadata.rowLinageEnabled());
+      if (metadata.nextRowId() > -1L) {

Review Comment:
   Should we check if the row lineage is enable as well as a defensive 
programming practice? Or we have to carry on the next row id no matter whether 
row lineage is enabled or not? cc @RussellSpitzer 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to