aokolnychyi commented on code in PR #11304: URL: https://github.com/apache/iceberg/pull/11304#discussion_r1910699260
########## api/src/test/java/org/apache/iceberg/util/TestCharSequenceMap.java: ########## @@ -88,20 +92,38 @@ public void testClear() { assertThat(map).isEmpty(); } + @Test + public void testKeySet() { + CharSequenceMap<String> map = CharSequenceMap.create(); + map.put("key1", "value1"); + map.put("key2", "value2"); Review Comment: Shall we use a mix of different CharSequences as input? Like `StringBuilder` or `StringBuffer`? ########## api/src/test/java/org/apache/iceberg/util/TestCharSequenceMap.java: ########## @@ -88,20 +92,38 @@ public void testClear() { assertThat(map).isEmpty(); } + @Test + public void testKeySet() { Review Comment: Can we add tests that keySets of different CharSequenceMaps match if they are equivalent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org