smaheshwar-pltr commented on code in PR #1452:
URL: https://github.com/apache/iceberg-python/pull/1452#discussion_r1909052866


##########
pyiceberg/table/__init__.py:
##########
@@ -1627,6 +1632,67 @@ class AddFileTask:
     partition_field_value: Record
 
 
+class LocationProvider(ABC):

Review Comment:
   I was inspired by `FileIO` here but this makes sense.
   
   It feels weird doing
   
   ```py
   from pyiceberg.table import (
       load_location_provider,
   )
   from pyiceberg.table.locations import LocationProvider
   ```
   
   everywhere so I'll move the loading stuff there too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to