smaheshwar-pltr commented on issue #1492: URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2580114664
> I hadn’t realized this feature is closely tied to LocationProvider. After looking into it, I think it could fit well with the changes you’re already working on. Would you like to handle it as part of your update, or would you prefer I continue working on it? Good suggestion @jiakai-li - I expressed my thoughts here: https://github.com/apache/iceberg-python/pull/1452#discussion_r1893970505. I'd prefer to keep https://github.com/apache/iceberg-python/pull/1452 as just what's needed to address the issue linked on it because: - as is, there are important discussions to be had regarding location provision alone, e.g. https://github.com/apache/iceberg-python/pull/1452#discussion_r1899070323 + https://github.com/apache/iceberg-python/pull/1452#pullrequestreview-2528159350, and - `write.metadata.path`, which feels like it should be supported along with `write.data.path`, is (as far as I understand) quite separate from those changes. IMO, we'd then doing too many things in that PR. I'd prefer that both of these new write options be tackled together in a follow-up PR, that closes this issue - let me know how this sounds to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
