dmgkeke opened a new issue, #11932:
URL: https://github.com/apache/iceberg/issues/11932

   ### Apache Iceberg version
   
   1.7.1 (latest release)
   
   ### Query engine
   
   Flink
   
   ### Please describe the bug 🐞
   
   I found a code suspected of being a bug while running rewrite data file 
flink action.
   Casting error occurs When binding the table structure and applying 
expression filter.
   From what I saw and understood the code, it seems to be an issue that 
occurred in the process of sanitize to string value.
   
   From the logic below, all value parameters delivered to the Object are 
delivered to the literal instance except for value method of the String 
Sanitizer.
   
   
https://github.com/apache/iceberg/blob/apache-iceberg-1.7.1/api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java#L514
   
   Therefore, I think it would be right to modify it as follows.
   
   ``` java
   // ExpressionUtils.StringSanitizer
   private String value(BoundLiteralPredicate<?> pred) {
         return sanitize(pred.term().type(), pred.literal(), nowMicros, today);
       }
   
   // ExpressionUtils
   private static String sanitize(Type type, Literal value, long now, int 
today) {
     // same code
   }
   ```
   
   or
   
   Change the pass parameters to literal.value() from where they are called.
   
   ### Willingness to contribute
   
   - [X] I can contribute a fix for this bug independently
   - [X] I would be willing to contribute a fix for this bug with guidance from 
the Iceberg community
   - [ ] I cannot contribute a fix for this bug at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to