nickdelnano opened a new pull request, #11923:
URL: https://github.com/apache/iceberg/pull/11923

   The [Spark Getting Started docs 
page](https://iceberg.apache.org/docs/nightly/spark-getting-started/) has intro 
Spark examples but they reference tables and columns that do not exist in the 
example tables. This is one of the first docs pages that new Iceberg users will 
see and having a correct example that someone can run themselves is helpful to 
them.
   
   I originally found these as I was reading the project's tests and saw the 
TODO's marked in SmokeTest.java
   ```
   // TODO Update doc example so that it can actually be run, modifications 
were required for this
   // test suite to run
   ```
   
   I've updated the docs in line with the test cases, and also made a minor 
change to the example a bit to make it more clear - each MERGE sets a unique 
`data` value for each `id`.
   
   
   ### Testing
   - [x] The tests modified in this PR pass
   - [x] Built the site locally as documented 
[here](https://github.com/apache/iceberg/blob/main/site/README.md) and loaded 
the modified page
   <img width="737" alt="Screenshot 2025-01-07 at 2 32 15 PM" 
src="https://github.com/user-attachments/assets/b6c72f16-4b6c-4d8f-b3f5-288bc8e6bf77";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to