nastra commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1905440692


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/ParquetWithSparkSchemaVisitor.java:
##########
@@ -59,106 +59,101 @@ public static <T> T visit(DataType sType, Type type, 
ParquetWithSparkSchemaVisit
     } else {
       // if not a primitive, the typeId must be a group
       GroupType group = type.asGroupType();
-      OriginalType annotation = group.getOriginalType();

Review Comment:
   there are a few more places in the codebase that use this, so maybe those 
places should be updated as well as part of this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to