Xuanwo commented on code in PR #872: URL: https://github.com/apache/iceberg-rust/pull/872#discussion_r1905099231
########## crates/iceberg/src/inspect/metadata_table.rs: ########## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use super::{ManifestsTable, SnapshotsTable}; +use crate::table::Table; + +/// Metadata table is used to inspect a table's history, snapshots, and other metadata as a table. +/// +/// References: +/// - <https://github.com/apache/iceberg/blob/ac865e334e143dfd9e33011d8cf710b46d91f1e5/core/src/main/java/org/apache/iceberg/MetadataTableType.java#L23-L39> +/// - <https://iceberg.apache.org/docs/latest/spark-queries/#querying-with-sql> +/// - <https://py.iceberg.apache.org/api/#inspecting-tables> +#[derive(Debug)] +pub struct MetadataTable(Table); Review Comment: > I don't quite understand why we need this data struct here. It seems just a wrapper to provide more api, while just like this: Yes, I intend to make the API exposed at `Table` more organized. For example, users will have: ```rust table.metadata_table().snapshots(); table.metadata_table().manifests(); ``` instead of: ```rust table.metadata_snapshots_table(); table.metadata_manifests_table(); ``` While I believe we could use better API names, such as `table.inspect()`, the overall structure looks good to me and aligns better with other implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
