pvary commented on PR #11750: URL: https://github.com/apache/iceberg/pull/11750#issuecomment-2572593083
> Spark (and other modules) also depend on `TestHiveMetastore` from test modules of `iceberg-hive-metastore`. We cannot use old Hive dependency from Spark to run this class due to API changes. `TestHiveMetastore` is a test only code. If we use a shaded version for testing and using our own Hive version for it, then it should be fine. For the production code: I would argue that if there are compatibility issues with the HMS Client (I don't know about any of them ATM), then as we use our own shaded avro version to write the manifest files, we probably HiveCatalog should use its own shaded HMSClient too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
