kevinjqliu commented on code in PR #1486:
URL: https://github.com/apache/iceberg-python/pull/1486#discussion_r1903366107
##########
.github/workflows/python-ci-docs.yml:
##########
@@ -40,8 +40,6 @@ jobs:
with:
python-version: 3.12
- name: Install
- working-directory: ./mkdocs
- run: pip install -r requirements.txt
- - name: Build
- working-directory: ./mkdocs
- run: mkdocs build --strict
+ run: make install
Review Comment:
im not sure if this is apple-to-apple.
alternatively, we can add the mkdoc deps as a new poetry group and just
install those
```
poetry install --docs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
