jiakai-li commented on code in PR #1485: URL: https://github.com/apache/iceberg-python/pull/1485#discussion_r1903333900
########## pyproject.toml: ########## @@ -859,6 +860,310 @@ ignore_missing_imports = true module = "tenacity.*" ignore_missing_imports = true +[[tool.mypy.overrides]] Review Comment: Not important, but just out of curiosity, is there a specific reason that we are not specifying modules in an array (e.g. [here](https://mypy.readthedocs.io/en/stable/config_file.html#:~:text=Multi%2Dmodule%20specific%20sections%20can%20be%20moved%20into%20a%20single%20%5B%5Btool.mypy.overrides%5D%5D%20section%20with%20a%20module%20property%20set%20to%20an%20array%20of%20modules%3A))? I can see `pytest.*` is declared twice in the file. I assume using a more compact syntax would be helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
