felixscherz commented on code in PR #1429:
URL: https://github.com/apache/iceberg-python/pull/1429#discussion_r1903296990
##########
tests/catalog/test_s3tables.py:
##########
@@ -0,0 +1,180 @@
+import uuid
+
+import boto3
+import pytest
+
+from pyiceberg.catalog.s3tables import S3TableCatalog
+from pyiceberg.exceptions import NoSuchNamespaceError, NoSuchTableError,
TableBucketNotFound
+from pyiceberg.schema import Schema
+from pyiceberg.types import IntegerType
+
+
+@pytest.fixture
+def database_name(database_name: str) -> str:
+ # naming rules prevent "-" in namespaces for s3 table buckets
+ return database_name.replace("-", "_")
+
+
+@pytest.fixture
+def table_name(table_name: str) -> str:
+ # naming rules prevent "-" in table namees for s3 table buckets
+ return table_name.replace("-", "_")
+
+
+@pytest.fixture
+def table_bucket_arn() -> str:
+ import os
+
+ # since the moto library does not support s3tables as of 2024-12-14 we
have to test against a real AWS endpoint
+ # in one of the supported regions.
+
+ return os.environ["ARN"]
+
+
+@pytest.fixture
+def catalog(table_bucket_arn: str) -> S3TableCatalog:
+ # pyarrow does not support writing to S3 Table buckets as of 2024-12-14
https://github.com/apache/iceberg-python/issues/1404#issuecomment-2543174146
+ properties = {"s3tables.table-bucket-arn": table_bucket_arn, "py-io-impl":
"pyiceberg.io.fsspec.FsspecFileIO"}
+ return S3TableCatalog(name="test_s3tables_catalog", **properties)
+
+
+def test_s3tables_api_raises_on_conflicting_version_tokens(table_bucket_arn:
str, database_name: str, table_name: str) -> None:
+ client = boto3.client("s3tables")
+ client.create_namespace(tableBucketARN=table_bucket_arn,
namespace=[database_name])
+ response = client.create_table(tableBucketARN=table_bucket_arn,
namespace=database_name, name=table_name, format="ICEBERG")
+ version_token = response["versionToken"]
+ scrambled_version_token = version_token[::-1]
+
+ warehouse_location = client.get_table(tableBucketARN=table_bucket_arn,
namespace=database_name, name=table_name)[
+ "warehouseLocation"
+ ]
+ metadata_location =
f"{warehouse_location}/metadata/00001-{uuid.uuid4()}.metadata.json"
+
+ with pytest.raises(client.exceptions.ConflictException):
+ client.update_table_metadata_location(
+ tableBucketARN=table_bucket_arn,
+ namespace=database_name,
+ name=table_name,
+ versionToken=scrambled_version_token,
+ metadataLocation=metadata_location,
+ )
+
+
+def test_s3tables_api_raises_on_preexisting_table(table_bucket_arn: str,
database_name: str, table_name: str) -> None:
+ client = boto3.client("s3tables")
+ client.create_namespace(tableBucketARN=table_bucket_arn,
namespace=[database_name])
+ client.create_table(tableBucketARN=table_bucket_arn,
namespace=database_name, name=table_name, format="ICEBERG")
+ with pytest.raises(client.exceptions.ConflictException):
+ client.create_table(tableBucketARN=table_bucket_arn,
namespace=database_name, name=table_name, format="ICEBERG")
+
+
+def test_creating_catalog_validates_s3_table_bucket_exists(table_bucket_arn:
str) -> None:
+ properties = {"s3tables.table-bucket-arn": f"{table_bucket_arn}-modified"}
+ with pytest.raises(TableBucketNotFound):
+ S3TableCatalog(name="test_s3tables_catalog", **properties)
+
+
+def test_create_namespace(catalog: S3TableCatalog, database_name: str) -> None:
+ catalog.create_namespace(namespace=database_name)
+ namespaces = catalog.list_namespaces()
+ assert (database_name,) in namespaces
+
+
+def test_load_namespace_properties(catalog: S3TableCatalog, database_name:
str) -> None:
+ catalog.create_namespace(namespace=database_name)
+ assert database_name in
catalog.load_namespace_properties(database_name)["namespace"]
Review Comment:
I think I misunderstood namespace properties. This method simply returns
metadata that AWS attaches to namespaces automatically.
I guess properties they are not supported by s3 tables since the API for
creating a namespace does not support any additional metadata:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3tables/client/create_namespace.html.
I'm going to change this to throw a `NotImplementedError` along with the
other namespace_properties methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
