flaneur2020 commented on code in PR #871:
URL: https://github.com/apache/iceberg-rust/pull/871#discussion_r1901839327
##########
crates/iceberg/src/metadata_scan.rs:
##########
@@ -183,21 +264,21 @@ impl<'a> ManifestsTable<'a> {
let mut existing_delete_files_count =
PrimitiveBuilder::<Int32Type>::new();
let mut deleted_delete_files_count =
PrimitiveBuilder::<Int32Type>::new();
let mut partition_summaries =
ListBuilder::new(StructBuilder::from_fields(
- Fields::from(self.partition_summary_fields()),
+ Fields::from(partition_summary_fields.clone()),
0,
))
- .with_field(Arc::new(Field::new_struct(
- "item",
- self.partition_summary_fields(),
- false,
- )));
+ .with_field(Arc::new(
+ Field::new_struct("item", partition_summary_fields,
false).with_metadata(
+ HashMap::from([("PARQUET:field_id".to_string(),
"9".to_string())]),
+ ),
Review Comment:
also ugly here 😲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
