liurenjie1024 commented on code in PR #862:
URL: https://github.com/apache/iceberg-rust/pull/862#discussion_r1901523435
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -626,6 +626,12 @@ impl TableMetadata {
Ok(())
}
+
+ /// Returns snapshot references.
+ #[inline]
+ pub fn snapshot_refs(&self) -> &HashMap<String, SnapshotReference> {
Review Comment:
Why we add this method? We already have lookup method for snapshot
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -255,7 +255,7 @@ pub struct TableCreation {
/// TableCommit represents the commit of a table in the catalog.
#[derive(Debug, TypedBuilder)]
-#[builder(build_method(vis = "pub(crate)"))]
+#[builder(build_method(vis = "pub"))]
Review Comment:
The reason we make `TableCommit` crate only is that we don't want to allow
user to build it manually, all table commits construction should go through
transaction api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
