manuzhang commented on PR #11612: URL: https://github.com/apache/iceberg/pull/11612#issuecomment-2568552990
@flyrain Thanks for taking a look. I think what might be confusing is `startSnapshotId` and `endSnapshotId` could be passed in or calculated from `startTimestamp` and `endTimestamp`. Skip scan is only possible in the latter case. That's why everything is inside `startTimestamp != null || endTimestamp != null`. There are three cases we can skip scan based on the result of the calculation. 1. both `startSnapshot` and `endSnapshot` are `null` 2. `endSnapshot` is `null` (`endTimestamp == null` ensures this is from calculation) 3. `startSnapshot` equals to `endSnapshot` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
