rshkv commented on code in PR #863:
URL: https://github.com/apache/iceberg-rust/pull/863#discussion_r1901252514
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -814,6 +814,193 @@ get_parquet_stat_as_datum!(min);
get_parquet_stat_as_datum!(max);
+/// Utilities to deal with [arrow_array::builder] types in the Iceberg context.
+pub(crate) mod builder {
+ use arrow_array::builder::*;
+ use arrow_array::cast::AsArray;
+ use arrow_array::types::*;
+ use arrow_array::{ArrayRef, Datum as ArrowDatum};
+ use arrow_schema::{DataType, TimeUnit};
+ use ordered_float::OrderedFloat;
+
+ use crate::spec::{Literal, PrimitiveLiteral};
+ use crate::{Error, ErrorKind};
+
+ /// A helper wrapping [ArrayBuilder] for building arrays without declaring
the inner type at
+ /// compile-time when types are determined dynamically (e.g. based on some
column type).
+ /// A [DataType] is given at construction time which is used to later
downcast the inner array
+ /// and provided values.
+ pub(crate) struct AnyArrayBuilder {
+ data_type: DataType,
+ inner: Box<dyn ArrayBuilder>,
+ }
Review Comment:
I appreciate this is quite verbose and I wish we didn't have to do all the
pattern matching below. If you think of a another way to do this let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
