Xuanwo commented on code in PR #797: URL: https://github.com/apache/iceberg-rust/pull/797#discussion_r1900575269
########## crates/iceberg/src/spec/manifest.rs: ########## @@ -1237,7 +1237,7 @@ pub fn write_data_files_to_avro<W: Write>( } /// Parse data files from avro bytes. -pub fn parse_data_file_from_avro<R: Read>( +pub fn read_data_file_from_avro<R: Read>( Review Comment: Hi, it returns `Vec<DataFile>` instead of `DataFile`, so `read_data_file_from_avro` is an incorrect API name. It would be better to rename it to `read_data_files_from_avro`. Alternatively, we could rename `write_data_files_to_avro` to `write_data_file_to_avro` to eliminate the concept of plurals from our API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
