lewiszlw commented on code in PR #856: URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899234586
########## CONTRIBUTING.md: ########## @@ -116,7 +116,7 @@ cargo 1.69.0 (6e9a83356 2023-04-12) Currently, iceberg-rust uses Docker to set up environment for integration tests. Native Docker has some limitations, please check (https://github.com/apache/iceberg-rust/pull/748). Please use Orbstack or Podman. -For MacOS users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative. +For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md). Review Comment: We have podman guide in repo. I think adding orbstack guide is helpful to new contributer as it's not trival to run tests like other rust projects, we should lower the threshold for new contributers as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
