okumin commented on code in PR #11880:
URL: https://github.com/apache/iceberg/pull/11880#discussion_r1898789437


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -344,7 +344,7 @@ int findVersion() {
 
         return maxVersion;
       } catch (IOException io) {
-        LOG.warn("Error trying to recover version-hint.txt data for {}", 
versionHintFile, e);
+        LOG.warn("Error trying to recover the latest version number for {}", 
versionHintFile, io);

Review Comment:
   `version-hint.txt` is not correct. Based on [this 
discussion](https://github.com/apache/iceberg/pull/11880#discussion_r1898764744),
 I replaced it with a more informative and non-redundant expression, as 
`versionHintFile` already includes the filename.
   
   This is the new message.
   
   ```
   Error trying to recover the latest version number for 
file:/var/folders/0n/191xk_2s2_3dbz7t6_jpws100000gn/T/junit-8523266742929144891/metadata/version-hint.text
   ```
   
   Additionally, this change would make the message capture `io` instead of `e` 
so that users can quickly identify the direct cause.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to