sdd commented on PR #652: URL: https://github.com/apache/iceberg-rust/pull/652#issuecomment-2560086936
FAO @liurenjie1024, @Xuanwo, @Fokko: I've finished refactoring this and after a few rounds I'm happier with the design of the `DeleteFileIndex` and how it is interacted with in the scan plan phase. I will follow up once this is merged with another PR similar to @Xuanwo's [recent one](https://github.com/apache/iceberg-rust/pull/806) as I think we can use similar techniques in the scan plan. I've got a few TODOs in here that mark behaviour that I was unsure of and could do with feedback upon, as well as to indicate missing parts that will be addressed in follow-up PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
