Fokko commented on code in PR #11731: URL: https://github.com/apache/iceberg/pull/11731#discussion_r1893985933
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java: ########## @@ -59,6 +59,12 @@ public void close() { accessor.close(); } + @Override Review Comment: Did we land on adding the `@Override`? Now it doesn't compile against Spark 3.5.2. Leaving out the annotation is safer (it will still work with ≥3.5.4). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org