smaheshwar-pltr commented on PR #1452: URL: https://github.com/apache/iceberg-python/pull/1452#issuecomment-2557074217
@Fokko (maybe @kevinjqliu also?) I've smoke-tested these changes locally with a catalog (hashing is the same as the Java implementation too), would love to get a first pass of this if you have a moment! Tests will come soon of course - can't seem to get integration tests to work locally, that's all. Maybe unit-tests for hashing is all that's required, but I feel like an integration test(s) would be nice to make sure it's wired up correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
