liurenjie1024 commented on PR #824: URL: https://github.com/apache/iceberg-rust/pull/824#issuecomment-2552646185
> I found an alternative to `sccache`: `swatinem/rust-cache@v2` (also approved by ASF) > > They work differently: > > * `sccache` writes/reads cache for each individual build artifact. > * `rust-cache` has a large cache for all dependencies (keyed by `Cargo.toml` and `Cargo.lock`) > > It's possible that `rust-cache` works better with GHA cache. But we will need to check in `Cargo.lock` (currently ignored) to make it work better. (We can consider doing it, and it has other benefits like a reproduciable build for CI and all developers.) > > IMO sticking with `sccache` is also not too bad as it seems simpler to me I'm not a big fan of checking in `Cargo.lock` as it's an antipattern for library. I think sscache is good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
