rdblue commented on code in PR #11803:
URL: https://github.com/apache/iceberg/pull/11803#discussion_r1890492591
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java:
##########
@@ -268,4 +279,59 @@ private static <T> List<T> toJavaList(Seq<T> seq) {
private static String toExecutorLocation(BlockManagerId id) {
return ExecutorCacheTaskLocation.apply(id.host(),
id.executorId()).toString();
}
+
+ /**
+ * Converts a value to pass into Spark from Iceberg's internal object model.
+ *
+ * @param type an Iceberg type
+ * @param value a value that is an instance of {@link
Type.TypeID#javaClass()}
+ * @return the value converted for Spark
+ */
+ public static Object convertConstant(Type type, Object value) {
Review Comment:
Good point, I'll update it in my follow up that is fixing a few types and
adding a test for each primitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
