pan3793 commented on code in PR #11802:
URL: https://github.com/apache/iceberg/pull/11802#discussion_r1889502230
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##########
@@ -59,6 +59,10 @@ public void close() {
accessor.close();
}
+ // If a column vector is writable or constant, it should override this
method and do nothing.
+ // See more details at SPARK-50235, SPARK-50463 (Fixed in Spark 3.5.4)
+ public void closeIfFreeable() {}
Review Comment:
w/ or w/o `@Override` won't cause any functional difference.
do you guys want to wait for Spark 3.5.4 to pass the vote, or release
Iceberg 1.7.2 ASAP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
