huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1889490436
########## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java: ########## @@ -214,7 +215,7 @@ public void testWriteWithCaseSensitiveOption() throws NoSuchTableException, Pars Assert.assertEquals(4, fields.size()); } - @Test + @Ignore Review Comment: I am ignoring three tests for now with the Comet configuration. This is only for testing purposes within Comet. I will revert these changes after the PR review. In the followup PR, I will make `SparkScan` implement `org.apache.comet.parquet.SupportsComet`, and then Comet will check the flag in `org.apache.comet.parquet.SupportsComet` to turn on the native operators. Additionally, Comet will allow conversion from int to long and float to double based on the flag in `org.apache.comet.parquet.SupportsComet`, which means, these tests will pass after the followup PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org