Fokko commented on code in PR #1385: URL: https://github.com/apache/iceberg-python/pull/1385#discussion_r1889157560
########## pyiceberg/table/snapshots.py: ########## @@ -239,9 +239,7 @@ class Snapshot(IcebergBaseModel): parent_snapshot_id: Optional[int] = Field(alias="parent-snapshot-id", default=None) sequence_number: Optional[int] = Field(alias="sequence-number", default=INITIAL_SEQUENCE_NUMBER) timestamp_ms: int = Field(alias="timestamp-ms", default_factory=lambda: int(time.time() * 1000)) - manifest_list: Optional[str] = Field( - alias="manifest-list", description="Location of the snapshot's manifest list file", default=None - ) + manifest_list: str = Field(alias="manifest-list", description="Location of the snapshot's manifest list file", default=None) Review Comment: That's a great nit, thanks! ```suggestion manifest_list: str = Field(alias="manifest-list", description="Location of the snapshot's manifest list file") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org