gruuya commented on code in PR #814: URL: https://github.com/apache/iceberg-rust/pull/814#discussion_r1888623712
########## crates/iceberg/src/arrow/reader.rs: ########## @@ -195,12 +195,28 @@ impl ArrowReader { let should_load_page_index = row_selection_enabled && task.predicate.is_some(); + let mut reader_options = ArrowReaderOptions::new().with_page_index(should_load_page_index); + if task.schema.as_struct().fields().iter().any(|field| { + matches!( + field.field_type.as_ref(), + Type::Primitive(PrimitiveType::Int) + ) + }) { Review Comment: Ideally this would also be done only if the a field with this type is also one of the projected ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org