liurenjie1024 commented on PR #789: URL: https://github.com/apache/iceberg-rust/pull/789#issuecomment-2547437282
The reason why I suggest moving puffin into core crate is to avoid circulate dependency problem, thinking about the case we put it outside: 1. Puffer Read/Writer -> FileIO -> core crate 2. core crate -> planning/deletion vector processing -> puffin crate Usually I'm leaning toward to smaller crates so that user could choose a minimum set of dependencies. But if we really want to do this, we need to split core crate into smaller crates, for example file io, data reader/writer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
