sungwy commented on code in PR #809:
URL: https://github.com/apache/iceberg-rust/pull/809#discussion_r1887569858
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -398,33 +397,6 @@ impl TableMetadata {
self.partition_statistics.get(&snapshot_id)
}
- /// Append snapshot to table
- #[deprecated(
- since = "0.4.0",
- note = "please use `TableMetadataBuilder.set_branch_snapshot` instead"
- )]
Review Comment:
Yes, my bad - I read this as having to remove it by `0.4.0`, reverting
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -192,13 +191,6 @@ impl Snapshot {
partition_type_provider,
)
}
-
- pub(crate) fn log(&self) -> SnapshotLog {
Review Comment:
Yes, it's because deprecated function `append_snapshot` is the only function
that calls it. Since we are reverting that change, I will revert this as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
