osscm commented on code in PR #11781: URL: https://github.com/apache/iceberg/pull/11781#discussion_r1884308287
########## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ########## @@ -257,17 +257,17 @@ private static class Task<T> implements Supplier<Optional<Task<T>>>, Closeable { @Override public Optional<Task<T>> get() { try { + if (queue.size() >= approximateMaxQueueSize) { Review Comment: https://github.com/apache/iceberg/pull/11781/files#diff-0586c055bbd9d220727cfa60c802321693a959c0cfb3a510376fc5a5bb1dc897R99 `this.taskFutures = new CompletableFuture[2 * ThreadPools.WORKER_THREAD_POOL_SIZE];` here the global thread pool size is driving the taskFuture array size, can this leads to more tasks then the available S3 connections? as I believe each table scan will create a new `ParallelIterable` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org