gruuya commented on code in PR #785:
URL: https://github.com/apache/iceberg-rust/pull/785#discussion_r1883721441
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -1180,4 +1194,62 @@ mod tests {
assert_eq!(visitor.field_ids, expected);
}
+
+ #[test]
+ fn test_arrow_projection_mask() {
Review Comment:
I've slightly revised the existing test now. It tests a parquet/arrow schema
with one supported type, one unsupported type and one with a decimal with a
precision beyond the supported range. It asserts that projection masks fails
until the projection leaves out the last two fields.
Granted it's a bit of a stretch to think how this could come up in practice,
but it does exercise the proposed changes in this PR nonetheless. Let me know
if this is close to what you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
