Ppei-Wang commented on code in PR #11751:
URL: https://github.com/apache/iceberg/pull/11751#discussion_r1882185303
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1414,7 +1414,42 @@ public void describeExtendedView() {
String.format(
"['format-version' = '1', 'location' = '%s', 'provider' =
'iceberg']",
location),
- ""));
+ ""),
+ row("View Text", sql, ""));
+ }
+
+ @TestTemplate
+ public void describeExtendedViewWithoutCurrentNamespace() {
Review Comment:
@nastra but at org/apache/spark/sql/connector/catalog/View.java is defined
that
```
public interface View {
...
/**
* The current catalog when the view is created.
*/
String currentCatalog();
/**
* The current namespace when the view is created.
*/
String[] currentNamespace();
...
}
```
---------------------------
i think above changes have a bit conflicting？
and my suggestion is that added catalog and namespace of view itself at
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java.
Also change initialization accordingly in create view comand and desc extended
view command. what about this idea？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
