creechy opened a new issue, #11767:
URL: https://github.com/apache/iceberg/issues/11767

   ### Apache Iceberg version
   
   None
   
   ### Query engine
   
   None
   
   ### Please describe the bug 🐞
   
   This is a little nit-picky, but the Iceberg REST spec defines the response 
of the UpdateTable (commit) operation to be `CommitTableResponse` 
   
   
https://github.com/apache/iceberg/blob/d402f83fc7b224b21242c506cf503e5bcbc8c867/open-api/rest-catalog-open-api.yaml#L1004
   
   But the code implementing UpdateTable (commit) uses `LoadTableResponse` to 
hold the results of the operation. 
   
   
https://github.com/apache/iceberg/blob/6c05f35e67093491aa054d0b41b1ada367df1072/core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java#L158
   
   `LoadTableReponse` appears to be a superset of `CommitTableResponse`, and 
the subsequent code that uses the response only uses fields in the latter, but 
it is a little misleading for the casual reader who may expect all the data 
from `LoadTableResponse` to be available. 
   
   ### Willingness to contribute
   
   - [ ] I can contribute a fix for this bug independently
   - [X] I would be willing to contribute a fix for this bug with guidance from 
the Iceberg community
   - [ ] I cannot contribute a fix for this bug at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to