wzx140 commented on code in PR #11748: URL: https://github.com/apache/iceberg/pull/11748#discussion_r1881295827
########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ########## @@ -275,7 +275,7 @@ public void testRewriteFilter() throws Exception { .execute(); List<DeleteFile> newDeleteFiles = except(deleteFiles(table), deleteFiles); - assertThat(newDeleteFiles).as("Should have 4 delete files").hasSize(2); + assertThat(newDeleteFiles).as("Should have 2 delete files").hasSize(2); Review Comment: @ebyhr @huaxingao @szehon-ho I think this suggestion is reasonable, but there are many similar assertions in the existing uts. Should we work together to update them as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org