sungwy commented on PR #1423: URL: https://github.com/apache/iceberg-python/pull/1423#issuecomment-2536123513
Hi @jiakai-li - thank you for reporting this issue and putting up this PR! The behavior looks right to me, but I think it would be worth thinking through this behavior change holistically. In `_DeleteFiles` we also build partition projection using `inclusive_projection` where we only support `case_sensitive` matching. https://github.com/apache/iceberg-python/blob/ede363bd63640f3db6c3b3d6904a5765dafd2600/pyiceberg/table/update/snapshot.py#L340-L344 If we introduce `case_sensitive=False` as a behavior that can be controlled by the user on DataScan for `inclusive_projection`, I think its worth also thinking if we want to introduce a discrepancy in our behaviors based on API, or if we should be keeping a consistent behavior (one way or another). Tagging @Fokko for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
