nastra commented on code in PR #11744:
URL: https://github.com/apache/iceberg/pull/11744#discussion_r1879895668
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -867,18 +867,17 @@ private List<DeleteFile> deleteFiles(Table table) {
}
private <T extends ContentFile<?>> List<T> except(List<T> first, List<T>
second) {
- Set<String> secondPaths =
- second.stream().map(f ->
f.path().toString()).collect(Collectors.toSet());
+ Set<String> secondPaths = second.stream().map(f ->
f.location()).collect(Collectors.toSet());
return first.stream()
- .filter(f -> !secondPaths.contains(f.path().toString()))
+ .filter(f -> !secondPaths.contains(f.location()))
.collect(Collectors.toList());
}
private void assertNotContains(List<DeleteFile> original, List<DeleteFile>
rewritten) {
Set<String> originalPaths =
- original.stream().map(f ->
f.path().toString()).collect(Collectors.toSet());
+ original.stream().map(f -> f.location()).collect(Collectors.toSet());
Review Comment:
nit: there are a bunch of places like this which can be updated to
`.map(ContentFile::location)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
