Fokko commented on code in PR #762:
URL: https://github.com/apache/iceberg-rust/pull/762#discussion_r1877920195
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -213,7 +213,7 @@ impl SchemaVisitor for IndexByParquetPathName {
pub struct ParquetWriter {
schema: SchemaRef,
out_file: OutputFile,
- writer: AsyncArrowWriter<AsyncFileWriter<TrackWriter>>,
+ writer: AsyncArrowWriter<AsyncFileWriter<TrackWriter<opendal::Writer>>>,
Review Comment:
I'm reluctant to have 3rd party classes in our API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
