danielcweeks commented on code in PR #11728:
URL: https://github.com/apache/iceberg/pull/11728#discussion_r1876894346


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -412,6 +413,24 @@ public String toString() {
     }
   }
 
+  public static class NullType extends PrimitiveType {

Review Comment:
   @Ppei-Wang `Null` is not an Iceberg type.  `Unknown` was added as part of v3 
spec, but this needs to be handled carefully.
   
   I don't think we can introduce the way you've outlined here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to