ajreid21 commented on issue #11213: URL: https://github.com/apache/iceberg/issues/11213#issuecomment-2529358516
The ExpireSnaphots procedure does 2 things: 1. Removes old snapshots from table's metadata. 2. Deletes expired files (files no longer reachable after removing snapshots from table). Would the expectation be that if you set `dry_run` to true that only #2 is _simulated_? IMO, I think that would be a different parameter such as `cleanup_expired_files` which would default to true and if false, the procedure wouldn't delete any files (and those files would now be considered orphan files that would/could be cleaned up by the orphan files procedure). But this probably wouldn't provide what you wanted as I don't think it would return _simulated_ results for the deletes (the delete results would be 0). I think if we added a `dry_run` parameter that if set to true, it wouldn't remove old snapshots, nor remove files, just return info on what would happen (wonder if we should also add # of expired snapshots to the result set 🤔 ). I can try and add either or both of these, just wondering what people think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
