HonahX commented on code in PR #11730:
URL: https://github.com/apache/iceberg/pull/11730#discussion_r1875481834
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -307,6 +311,13 @@ public String toString() {
Preconditions.checkArgument(
metadataFileLocation == null || changes.isEmpty(),
"Cannot create TableMetadata with a metadata location and changes");
+ Preconditions.checkArgument(
+ !rowLineageEnabled || formatVersion == 3,
+ "Row lineage is only supported in v3 (current version v%s)",
+ formatVersion);
+ Preconditions.checkArgument(
+ !rowLineageEnabled || nextRowId >= 0,
Review Comment:
Theoretically, `next-row-id` can start from any integer, including negative
ones. I am thinking may be in the implementation we could make it starts from 0
to simplify the implementation and make it more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
