singhpk234 commented on code in PR #11700: URL: https://github.com/apache/iceberg/pull/11700#discussion_r1870486963
########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ########## @@ -283,6 +286,12 @@ public void testRewriteFilter() throws Exception { List<Object[]> actualDeletes = deleteRecords(table); assertEquals("Rows must match", expectedRecords, actualRecords); assertEquals("Position deletes must match", expectedDeletes, actualDeletes); + + sql("set %s = true", SQLConf.CASE_SENSITIVE().key()); + assertThatThrownBy( Review Comment: can we use `withSQLConf` as this might cause if we use re:use spark session ? -https://github.com/apache/iceberg/blob/36140b819c60743b39176e28a63ab588df445329/spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBase.java#L184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org