smaheshwar-pltr commented on PR #11699: URL: https://github.com/apache/iceberg/pull/11699#issuecomment-2518783438
@danielcweeks Thanks a lot for taking a look! As it stands, I agree that clean-up happens correctly between tests (this PR was meant to be a small improvement, not a fix), but with a `beforeEach` instead of an `afterEach` for the clean-up, I think that running the RCK on a real catalog may leave spurious tables created by the last RCK test (after which clean up wouldn't occur). Maybe I'm misunderstanding something, but this sounded slightly undesirable in a similar (but less dire) way that deleting real data does, which maybe prompted the `beforeAll` check. But I understand that if this was a safety check, this scenario and so PR might not be meaningful to consider - happy for it to be closed in that case, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
