danielcweeks commented on code in PR #11692:
URL: https://github.com/apache/iceberg/pull/11692#discussion_r1870396800


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -189,6 +208,20 @@ void initialize(
     this.warehousePath = Strings.isNullOrEmpty(path) ? null : 
LocationUtil.stripTrailingSlash(path);
     this.glue = client;
     this.lockManager = lock;
+    this.extensionsEnabled =
+        PropertyUtil.propertyAsBoolean(
+            catalogProperties, 
GlueExtensionsProperties.GLUE_EXTENSIONS_ENABLED, true);

Review Comment:
   It looks like you're defaulting the extensions to be enabled, but does this 
require the glue bundle/runtime to work?  Why do we need to disable it for all 
of the tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to