kevinjqliu commented on PR #1396: URL: https://github.com/apache/iceberg-python/pull/1396#issuecomment-2515885124
Ok looks like RAT v0.15 does not scan hidden directories by default. See similar issue [apache/datafusion#9851](https://github.com/apache/datafusion/issues/9851) The [Java Iceberg repo has updated the `check-license` script to use RAT v0.16.1](https://github.com/apache/iceberg/blob/6501d29b2d46c8d57f46ad646e2daf7d8865f646/dev/check-license) with the `--scan-hidden-directories` option ([apache/iceberg #9495](https://github.com/apache/iceberg/pull/9495) and [apache/iceberg #9579](https://github.com/apache/iceberg/pull/9579)). This change should catch the missing ASF headers in the `./github` dir @manuzhang do you mind including this in the current PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
