amogh-jahagirdar commented on code in PR #11693:
URL: https://github.com/apache/iceberg/pull/11693#discussion_r1868313674
##########
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##########
@@ -36,6 +36,14 @@ public interface DVFileWriter extends Closeable {
*/
void delete(String path, long pos, PartitionSpec spec, StructLike partition);
+ default void delete(
Review Comment:
JavaDoc, also worth explaining the alternative which is calling delete for
every position.....but I think it's worth introducing an API on the writer
which takes an in memory index and merges that with the current writer state,
and writes out all the deleted positions. Almost like a batchDelete API on the
writer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
