pvary commented on code in PR #11497: URL: https://github.com/apache/iceberg/pull/11497#discussion_r1868100304
########## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TaskResultAggregator.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.util.Iterator; +import java.util.List; +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.state.ListState; +import org.apache.flink.api.common.state.ListStateDescriptor; +import org.apache.flink.api.common.typeinfo.BasicTypeInfo; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.runtime.state.StateInitializationContext; +import org.apache.flink.runtime.state.StateSnapshotContext; +import org.apache.flink.streaming.api.operators.AbstractStreamOperator; +import org.apache.flink.streaming.api.operators.TwoInputStreamOperator; +import org.apache.flink.streaming.api.watermark.Watermark; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.util.OutputTag; +import org.apache.flink.util.Preconditions; +import org.apache.iceberg.flink.maintenance.api.TaskResult; +import org.apache.iceberg.flink.maintenance.api.Trigger; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Aggregates results of the operators for a given maintenance task. + * + * <ul> + * <li>Input 1 is used: + * <ul> + * <li>To provide the {@link TaskResult#startEpoch()} - should be chained to the task input + * <li>To mark that the task is finished - should be chained at the end of the task, so an + * incoming watermark will signal that the task is finished + * </ul> + * <li>Input 2 expects an {@link Exception} which caused the failure - should be chained to the + * {@link #ERROR_STREAM} of the operators + * </ul> + * + * The operator emits a {@link TaskResult} with the overall result on {@link Watermark}. + */ +@Internal +public class TaskResultAggregator extends AbstractStreamOperator<TaskResult> + implements TwoInputStreamOperator<Trigger, Exception, TaskResult> { + public static final OutputTag<Exception> ERROR_STREAM = + new OutputTag<>("error-stream", TypeInformation.of(Exception.class)); + + private static final Logger LOG = LoggerFactory.getLogger(TaskResultAggregator.class); + + private final String tableName; + private final String taskName; + private final int taskIndex; + private transient Long startTime; + private transient List<Exception> exceptions; + private transient ListState<Long> startTimeState; + private transient ListState<Exception> exceptionsState; + + public TaskResultAggregator(String tableName, String taskName, int taskIndex) { + org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkNotNull( + tableName, "Table name should no be null"); + org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkNotNull( + taskName, "Task name should no be null"); + + this.tableName = tableName; + this.taskName = taskName; + this.taskIndex = taskIndex; + } + + @Override + public void initializeState(StateInitializationContext context) throws Exception { + super.initializeState(context); + this.startTimeState = + context + .getOperatorStateStore() + .getListState( + new ListStateDescriptor<>( + "result-aggregator-start-time", BasicTypeInfo.LONG_TYPE_INFO)); + this.exceptionsState = Review Comment: When does the Exception change? What do you suggest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
