Fokko commented on code in PR #11378:
URL: https://github.com/apache/iceberg/pull/11378#discussion_r1867655469
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -291,6 +291,13 @@ public ParquetValueReader<?> struct(
return createStructReader(types, reorderedFields, expected);
}
+ private int findIdFromStruct(Types.StructType expected, Type field) {
+ if (field.getId() != null) {
+ return field.getId().intValue();
+ }
+ return expected.field(field.getName()).fieldId();
Review Comment:
Any time, thank you for the PR, but I'm afraid that it will cause issues
downstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
