nastra commented on code in PR #11053:
URL: https://github.com/apache/iceberg/pull/11053#discussion_r1867552386


##########
.palantir/revapi.yml:
##########
@@ -1100,6 +1100,12 @@ acceptedBreaks:
     - code: "java.class.removed"
       old: "enum org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus"
       justification: "Removing deprecated code"
+    - code: "java.method.parameterTypeChanged"

Review Comment:
   unfortunately we can't just break APIs. You would have you create an 
additional method and deprecate the old one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to