pvary commented on code in PR #11497:
URL: https://github.com/apache/iceberg/pull/11497#discussion_r1867119084
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DeleteFilesProcessor.java:
##########
@@ -40,17 +41,17 @@ public class DeleteFilesProcessor extends
AbstractStreamOperator<Void>
implements OneInputStreamOperator<String, Void> {
private static final Logger LOG =
LoggerFactory.getLogger(DeleteFilesProcessor.class);
- private final String taskIndex;
+ private final String tableName;
private final String taskName;
+ private final int taskIndex;
private final SupportsBulkOperations io;
- private final String tableName;
private final Set<String> filesToDelete = Sets.newHashSet();
private final int batchSize;
private transient Counter failedCounter;
private transient Counter succeededCounter;
- public DeleteFilesProcessor(int taskIndex, String taskName, Table table, int
batchSize) {
+ public DeleteFilesProcessor(Table table, String taskName, int taskIndex, int
batchSize) {
Review Comment:
There are multiple places where we have these method parameters. Since we
are in the early stages, I have decided to standardize the order. Starting from
the widest going to the narrowest filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
